Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: Source/core/dom/Element.cpp

Issue 832083008: Allow Spatial Navigation ignore elements with event handlers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: new approach Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/page/SpatialNavigation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index c3848e786e7c5dc45f6e3d87db757a574632ec2a..34731113ea09d26f373bfa93f774789d6bad6a0a 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -2236,8 +2236,7 @@ bool Element::supportsSpatialNavigationFocus() const
// i.e. checks if click or keyboard event handler is specified.
// This is the way to make it possible to navigate to (focus) elements
// which web designer meant for being active (made them respond to click events).
-
- if (!isSpatialNavigationEnabled(document().frame()))
+ if (!isSpatialNavigationEnabled(document().frame()) || spatialNavigationIgnoresEventHandlers(document().frame()))
return false;
if (hasEventListeners(EventTypeNames::click)
|| hasEventListeners(EventTypeNames::keydown)
« no previous file with comments | « no previous file | Source/core/page/SpatialNavigation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698