Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 832083003: Revert of Enable display list 2D canvas by default (Closed)

Created:
5 years, 11 months ago by falken
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/818443002/) Reason for revert: WebKit XP bot has lots of LayoutTest failures and crashes in virtual/display_list_2d_canvas and virtual/gpu/fast/canvas. See eg: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16116 The commit log suggests --dump-render-tree is not affected by this change, but I don't see another likely culprit (unless https://src.chromium.org/viewvc/blink?view=rev&revision=187932) The failures started on: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16113 Chrome revision range: https://chromium.googlesource.com/chromium/src/+log/5b35ed504ba27664bc0b7d7320f2ebdf610decdc..3a5e72899629e0c8d254109707e747742686fbca Blink revision range: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=187921%3A187936&mode=html Original issue's description: > Enable display list 2D canvas by default > > With this change, display list 2D canvas will become enabled by > default in Chrome. Content shell with --dump-render-tree will > continue to have display lists disabled by default. > Currently, having display lists enabled in blink means > that display lists will be used whenever 2d canvases would > not be GPU-accelerated. > > BUG=386601 > > Committed: https://crrev.com/1546f423005338aac5961415bbfc48c61dc183ae > Cr-Commit-Position: refs/heads/master@{#309453} TBR=avi@chromium.org,junov@chromium.org NOTREECHECKS=true NOTRY=true BUG=386601 Committed: https://crrev.com/b314d341e5c60c03aa118e96318d54a84f00b053 Cr-Commit-Position: refs/heads/master@{#310252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M content/child/runtime_features.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
Created Revert of Enable display list 2D canvas by default
5 years, 11 months ago (2015-01-07 08:36:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832083003/1
5 years, 11 months ago (2015-01-07 08:36:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 08:37:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b314d341e5c60c03aa118e96318d54a84f00b053 Cr-Commit-Position: refs/heads/master@{#310252}
5 years, 11 months ago (2015-01-07 08:38:17 UTC) #4
falken
5 years, 11 months ago (2015-01-07 10:55:44 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/837123003/ by falken@chromium.org.

The reason for reverting is: Reverting did not solve the Win XP failures..

Powered by Google App Engine
This is Rietveld 408576698