Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 831993005: Remove custom element type extensions. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove custom element type extensions. Sky doesn't really have many built in elements, we no longer support <foo is="my-element">. This does mean you can't extend <import>, <script> or <style>, but we'll figure that out later. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f6084ddd37d59dfb01da01d38d629c80bf9b227c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -119 lines) Patch
M sky/engine/bindings/core/v8/CustomElementConstructorBuilder.cpp View 2 chunks +4 lines, -12 lines 0 comments Download
M sky/engine/bindings/core/v8/V8HiddenValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementDescriptor.h View 2 chunks +5 lines, -15 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementDescriptorHash.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistrationContext.h View 1 chunk +1 line, -6 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistrationContext.cpp View 2 chunks +3 lines, -53 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistry.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistry.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
esprehn
5 years, 11 months ago (2015-01-06 23:59:40 UTC) #2
eseidel
lgtm
5 years, 11 months ago (2015-01-07 00:04:40 UTC) #4
abarth-chromium
LGTM
5 years, 11 months ago (2015-01-07 00:05:20 UTC) #6
esprehn
5 years, 11 months ago (2015-01-07 00:07:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f6084ddd37d59dfb01da01d38d629c80bf9b227c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698