Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 831953003: Disable webkit/array-iterate-backwards for debug builds. (Closed)

Created:
5 years, 11 months ago by vogelheim
Modified:
5 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable webkit/array-iterate-backwards for debug builds. (Debug builds have --enable-slow-asserts, and with slow asserts each assignment to the array in the prepare function will trigger a check over the entire array. This turns it into n^2 work, for reasonably large n.) BUG= Committed: https://crrev.com/c72c28dd00d8e027c5b1abb62689b6185dd07cd7 Cr-Commit-Position: refs/heads/master@{#26006}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M test/webkit/webkit.status View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vogelheim
I'll check whether this the same reason why it's disabled for TF runs. If so, ...
5 years, 11 months ago (2015-01-08 13:21:52 UTC) #3
vogelheim
On 2015/01/08 13:21:52, vogelheim wrote: > I'll check whether this the same reason why it's ...
5 years, 11 months ago (2015-01-08 13:40:49 UTC) #4
Michael Achenbach
lgtm
5 years, 11 months ago (2015-01-09 09:54:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831953003/20001
5 years, 11 months ago (2015-01-09 09:57:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 11 months ago (2015-01-09 10:27:10 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 10:27:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c72c28dd00d8e027c5b1abb62689b6185dd07cd7
Cr-Commit-Position: refs/heads/master@{#26006}

Powered by Google App Engine
This is Rietveld 408576698