Issue 831913003: PRESUBMIT: Ignore external_bin/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 831913003: PRESUBMIT: Ignore external_bin/. (Closed)

Created:
5 years, 11 months ago by Raphael Kubo da Costa (rakuco)

Modified:
5 years, 11 months ago

Reviewers:
Ryan Tseng, pgervais

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

PRESUBMIT: Ignore external_bin/. This is created for the external gsutil since r293320, and was creating needless churn in presubmit tests when it is present. R=pgervais@chromium.org,hinoka@google.com BUG=434422 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293574

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

Ryan Tseng

lgtm % please add "BUG=434422" to patch description. thanks.

5 years, 11 months ago (2015-01-08 19:10:08 UTC) #2

pgervais

On 2015/01/08 19:10:08, Ryan Tseng wrote: > lgtm % please add "BUG=434422" to patch description. ...

5 years, 11 months ago (2015-01-08 19:31:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831913003/1

5 years, 11 months ago (2015-01-08 22:25:44 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-08 22:28:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293574