Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: build/common.gypi

Issue 831863003: Start enforcing strict checks for {virtual,override,final} on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update per suggestions Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index bf3e7785d935cf81520a2102d362b43463fc221f..dac72f3457aa9ede3fe8deb57152f627c6be8057 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2137,6 +2137,18 @@
'clang_chrome_plugins_flags': [
'<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
],
+ 'conditions': [
+ # TODO(dcheng): https://crbug.com/417463 -- work to enable this flag
+ # on all platforms is currently underway.
+ ['OS=="linux" and chromeos==0', {
Nico 2014/12/31 01:35:56 (if this ends up breaking the official bots, you c
+ 'clang_chrome_plugins_flags': [
+ '-Xclang',
+ '-plugin-arg-find-bad-constructs',
+ '-Xclang',
+ 'strict-virtual-specifiers',
+ ],
+ }],
+ ],
}],
['asan==1 or msan==1 or lsan==1 or tsan==1', {
'clang%': 1,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698