Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/file_grid.js

Issue 831833004: Files.app: Stop to use drive thumbnail for cached files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/file_grid.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/file_grid.js b/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
index 8c0983325b62fc585cac77be424be0af3f0611b3..a7983a6babcf727b6c1a6b72ce0dd4c03b323259 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
@@ -240,19 +240,22 @@ FileGrid.decorateThumbnailBox = function(
var metadataTypes = 'thumbnail|filesystem|external|media';
- // Drive provides high quality thumbnails via USE_EMBEDDED, however local
- // images usually provide very tiny thumbnails, therefore USE_EMBEDDE can't
- // be used to obtain high quality output.
- var useEmbedded;
+ // CONTENT_METADATA contains usually very tiny thumbnails. So use it only for
+ // ThumbnailQuality.LOW.
+ var loadTargets;
switch (quality) {
case FileGrid.ThumbnailQuality.LOW:
- useEmbedded = ThumbnailLoader.UseEmbedded.USE_EMBEDDED;
+ loadTargets = [
+ ThumbnailLoader.LoadTarget.CONTENT_METADATA,
+ ThumbnailLoader.LoadTarget.EXTERNAL_METADATA,
+ ThumbnailLoader.LoadTarget.FILE_ENTRY
+ ];
break;
case FileGrid.ThumbnailQuality.HIGH:
- // TODO(mtomasz): Use Entry instead of paths.
- useEmbedded = (locationInfo && locationInfo.isDriveBased) ?
- ThumbnailLoader.UseEmbedded.USE_EMBEDDED :
- ThumbnailLoader.UseEmbedded.NO_EMBEDDED;
+ loadTargets = [
+ ThumbnailLoader.LoadTarget.EXTERNAL_METADATA,
+ ThumbnailLoader.LoadTarget.FILE_ENTRY
+ ];
break;
}
@@ -262,7 +265,7 @@ FileGrid.decorateThumbnailBox = function(
ThumbnailLoader.LoaderType.IMAGE,
metadata,
undefined, // opt_mediaType
- useEmbedded).
+ loadTargets).
load(box,
fillMode,
ThumbnailLoader.OptimizationMode.DISCARD_DETACHED,

Powered by Google App Engine
This is Rietveld 408576698