Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 831833003: Open folder as OK action when a folder is selected in save-as dialog. (Closed)

Created:
5 years, 11 months ago by fukino
Modified:
5 years, 11 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Open folder as OK action when a folder is selected in save-as dialog. BUG=441448 TEST=run browser_tests Committed: https://crrev.com/28db864a108d33357d3bb8cabb375a9565a10415 Cr-Commit-Position: refs/heads/master@{#310703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M ui/file_manager/file_manager/foreground/js/dialog_action_controller.js View 2 chunks +17 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
fukino
Could you take a look? Thanks!
5 years, 11 months ago (2015-01-08 06:56:16 UTC) #2
hirono
lgtm!
5 years, 11 months ago (2015-01-08 07:29:58 UTC) #3
fukino
On 2015/01/08 07:29:58, hirono wrote: > lgtm! Thanks!
5 years, 11 months ago (2015-01-08 07:50:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831833003/1
5 years, 11 months ago (2015-01-08 07:51:31 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 09:53:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831833003/1
5 years, 11 months ago (2015-01-09 03:22:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 03:30:44 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 03:31:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28db864a108d33357d3bb8cabb375a9565a10415
Cr-Commit-Position: refs/heads/master@{#310703}

Powered by Google App Engine
This is Rietveld 408576698