components/nacl/browser/nacl_browser_delegate.h - Issue 831813004: Get nacl building again for android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_browser_delegate.h

Issue 831813004: Get nacl building again for android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review comments addressed Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/browser/nacl_browser_delegate.h

diff --git a/components/nacl/browser/nacl_browser_delegate.h b/components/nacl/browser/nacl_browser_delegate.h

index bf23965709143709fc36fc8dab5acb8ac8964ac7..45c93b5676608d62e3ad7e901b01982946ab841d 100644

--- a/components/nacl/browser/nacl_browser_delegate.h

+++ b/components/nacl/browser/nacl_browser_delegate.h

@@ -68,7 +68,7 @@ class NaClBrowserDelegate {

const base::FilePath& profile_directory,

base::FilePath* file_path) = 0;

// Set match patterns which will be checked before enabling debug stub.

- virtual void SetDebugPatterns(std::string debug_patterns) = 0;

+ virtual void SetDebugPatterns(const std::string& debug_patterns) = 0;

// Returns whether NaCl application with this manifest URL should be debugged.

virtual bool URLMatchesDebugPatterns(const GURL& manifest_url) = 0;