extensions/shell/browser/shell_nacl_browser_delegate.h - Issue 831813004: Get nacl building again for android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_nacl_browser_delegate.h

Issue 831813004: Get nacl building again for android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment out CheckEnvVar Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/browser/shell_nacl_browser_delegate.h

diff --git a/extensions/shell/browser/shell_nacl_browser_delegate.h b/extensions/shell/browser/shell_nacl_browser_delegate.h

index 17723230f7b19ac9aff69294224c6c76c7850797..a0f0a3872241f85761beaf7281d6acffab1d92c5 100644

--- a/extensions/shell/browser/shell_nacl_browser_delegate.h

+++ b/extensions/shell/browser/shell_nacl_browser_delegate.h

@@ -39,7 +39,7 @@ class ShellNaClBrowserDelegate : public NaClBrowserDelegate {

bool is_blocking,

const base::FilePath& profile_directory,

base::FilePath* file_path) override;

- void SetDebugPatterns(std::string debug_patterns) override;

+ void SetDebugPatterns(const std::string& debug_patterns) override;

bool URLMatchesDebugPatterns(const GURL& manifest_url) override;

content::BrowserPpapiHost::OnKeepaliveCallback GetOnKeepaliveCallback()

override;