Issue 83173008: CQ: don't treat the commit box as unchecked on network errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83173008: CQ: don't treat the commit box as unchecked on network errors (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.

Modified:
7 years ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

CQ: don't treat the commit box as unchecked on network errors BUG=309076 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=237402

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -16 lines)			Patch
	M	commit-queue/pending_manager.py	View		2 chunks	+10 lines, -16 lines	1 comment	Download

Total messages: 5 (0 generated)

Paweł Hajdan Jr.

Please review. Just in case you ask, previous review was https://codereview.chromium.org/26951002 This is working fine ...

7 years, 1 month ago (2013-11-22 18:01:10 UTC) #1

Paweł Hajdan Jr.

On 2013/11/26 01:01:42, Isaac wrote: > lgtm but please add a bug per chase's request ...

7 years ago (2013-11-26 20:36:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/83173008/1

7 years ago (2013-11-26 20:37:05 UTC) #4

Message was sent while issue was closed.

Change committed as 237402