Fixing M32 crasher where closing of a windowed V1 app on a visiting desktop will cause crashes late…

Fixing M32 crasher where closing of a windowed V1 app on a visiting desktop will cause crashes later on

BUG=321374
TEST=unit test (and checked that the crash does not happen anymore by hand)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236828

[Mr4D (OOO till 08-26), 2013-11-22 17:54:16]

Please have a look!

[James Cook, 2013-11-22 19:06:08]

LGTM with nits

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
(right):

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc:1546: //
First test: Create an app when the user is not active.
nit: Where does the second test begin?  Or is this whole thing one test?

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc:1555: //
Trigger an update on the launcher item.
Is this a leftover comment?

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc:1606: //
Note: the closure ends and the browser will go away.
nit: This might be a little clearer if you eliminated the {} block and
explicitly used v1_app.reset().

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
File chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.h
(right):

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.h:10: //
MultiProfileBrowserStatusMonitor uses mainly the BrowserStatusMonitormonitor
nit: BrowserStatusMonitormonitor?

[Mr4D (OOO till 08-26), 2013-11-22 19:17:00]

Addressed! Many thanks!

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
(right):

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc:1546: //
First test: Create an app when the user is not active.
Changed the comment(s). Thanks!

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc:1555: //
Trigger an update on the launcher item.
In deed. Done

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc:1606: //
Note: the closure ends and the browser will go away.
On 2013/11/22 19:06:09, James Cook wrote:
> nit: This might be a little clearer if you eliminated the {} block and
> explicitly used v1_app.reset().

Done.

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
File chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.h
(right):

https://codereview.chromium.org/83173007/diff/1/chrome/browser/ui/ash/launche...
chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.h:10: //
MultiProfileBrowserStatusMonitor uses mainly the BrowserStatusMonitormonitor
On 2013/11/22 19:06:09, James Cook wrote:
> nit: BrowserStatusMonitormonitor?

Done.

[commit-bot: I haz the power, 2013-11-22 19:17:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/83173007/100001

[commit-bot: I haz the power, 2013-11-22 21:18:20]

Change committed as 236828