Hide ARM assembly memset symbols.

Hide ARM assembly memset symbols.

Prevent these symbols from being exported from any library which
includes skia by marking them .hidden, as they are implementation
details of skia.

BUG=skia:3303
Committed: https://skia.googlesource.com/skia/+/60f8353f683277f360c5a74e2905c8de987a2dfe

[Torne, 2015-01-13 16:19:18]

torne@chromium.org changed reviewers:
+ djsollen@google.com

[Torne, 2015-01-13 16:19:18]

Hi Derek, does this look okay to you? See linked bug and http://crbug.com/448386
for what I'm trying to accomplish :)

[mtklein, 2015-01-13 16:23:41]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-01-13 16:23:41]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-01-13 16:23:41]

lgtm

lgtm

[commit-bot: I haz the power, 2015-01-13 16:24:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/831663004/1

[djsollen, 2015-01-13 16:25:08]

https://codereview.chromium.org/831663004/diff/1/src/opts/memset.arm.S
File src/opts/memset.arm.S (right):

https://codereview.chromium.org/831663004/diff/1/src/opts/memset.arm.S#newcode20
src/opts/memset.arm.S:20: .global arm_memset32
I don't think you need .global if you are marking it as hidden.

[Torne, 2015-01-13 16:28:43]

On 2015/01/13 16:25:08, djsollen wrote:
> https://codereview.chromium.org/831663004/diff/1/src/opts/memset.arm.S
> File src/opts/memset.arm.S (right):
> 
>
https://codereview.chromium.org/831663004/diff/1/src/opts/memset.arm.S#newcode20
> src/opts/memset.arm.S:20: .global arm_memset32
> I don't think you need .global if you are marking it as hidden.

I think you do, as .local/.global/.weak is orthogonal to their visibility. If
the symbol isn't global then nothing outside this translation unit will be able
to refer to it at all.

[mtklein, 2015-01-13 16:32:43]

> I think you do, as .local/.global/.weak is orthogonal to their visibility. If
> the symbol isn't global then nothing outside this translation unit will be
able
> to refer to it at all.

This is also my understanding.

[commit-bot: I haz the power, 2015-01-13 16:37:36]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/60f8353f683277f360c5a74e2905c8de987a2dfe