Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 831653002: Create pdfium_unittests binary. (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
palmer, jam, brucedawson
CC:
pdfium-reviews_googlegroups.com, palmer, pawliger
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create pdfium_unittests binary. PDFium has not yet had a unit-tests binary, so introduce one based on the typical gtest framework. Also provide a small initial test fragment for fxcrt strings for instructional purposes. Naturally, doing so kicked out one corner case that isn't handled, we'll fix that in a separate patch. This is a small part of the testing strategy tracking bug. BUG=https://code.google.com/p/pdfium/issues/detail?id=62 R=brucedawson@chromium.org, palmer@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/336991da7a3d5682a572c01e0a149b6990d05594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
A core/src/fxcrt/fx_basic_bstring_unittest.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Please review.
5 years, 11 months ago (2014-12-29 20:11:52 UTC) #2
palmer
LGTM. Thanks!!
5 years, 11 months ago (2014-12-29 20:22:57 UTC) #4
brucedawson
lgtm
5 years, 11 months ago (2014-12-29 20:45:29 UTC) #5
Tom Sepez
5 years, 11 months ago (2014-12-29 21:56:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
336991da7a3d5682a572c01e0a149b6990d05594 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698