MacViews: Fix child window z-order and SetBounds

ui/views/test/widget_test_aura.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/test/widget_test.h"
 
 #include "ui/aura/window.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/views/widget/widget.h"
 
 namespace views {
 namespace test {
 
+namespace {
+
+// Perform a pre-order traversal of |children| and all descendants, looking for
+// |first| and |second|. If |first| is found before |second|, return true.
+// When a layer is found, it is set to null. Returns once |second| is found, or
+// when there are no children left.
+// Note that ui::Layer children are bottom-to-top stacking order.
+bool FindLayersInOrder(const std::vector<ui::Layer*>& children,
+                       const ui::Layer** first,
+                       const ui::Layer** second) {
+  for (const ui::Layer* child : children) {
+    if (child == *second) {
+      *second = nullptr;
+      return *first == nullptr;
+    }
+
+    if (child == *first)
+      *first = nullptr;
+
+    if (FindLayersInOrder(child->children(), first, second))
+      return true;
+
+    // If second is cleared without success, exit early with failure.
+    if (!*second)
+      return false;
+  }
+  return false;
+}
+
+}  // namespace
+
 // static
 void WidgetTest::SimulateNativeDestroy(Widget* widget) {
   delete widget->GetNativeView();
 }
 
 // static
 bool WidgetTest::IsNativeWindowVisible(gfx::NativeWindow window) {
   return window->IsVisible();
 }
 
 // static
+bool WidgetTest::IsWindowStackedAbove(Widget* above, Widget* below) {
+  CHECK(above->IsVisible());

[sky, 2015/01/08 04:17:44]

CHECKs aren't good for tests. If it hits it means the harness crashes and no
more tests run.

[tapted, 2015/01/08 09:07:56]

changed to EXPECT_TRUE. The thinking went that these were more of a precondition
for the function, but yeah - no need to CHECK - there's no imminent explosion.

+  CHECK(below->IsVisible());
+
+  ui::Layer* root_layer = above->GetNativeWindow()->GetRootWindow()->layer();
+
+  // Traversal is bottom-to-top, so |below| should be found first.
+  const ui::Layer* first = below->GetLayer();
+  const ui::Layer* second = above->GetLayer();
+  return FindLayersInOrder(root_layer->children(), &first, &second);
+}
+
+// static
 ui::EventProcessor* WidgetTest::GetEventProcessor(Widget* widget) {
   return widget->GetNativeWindow()->GetHost()->event_processor();
 }
 
 }  // namespace test
 }  // namespace views