content/public/common/context_menu_params.h - Issue 83163002: [Aura] Adding Writing direction to the context menu for Aura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/context_menu_params.h

Issue 83163002: [Aura] Adding Writing direction to the context menu for Aura. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Aura-CrOS-Win Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc ('K') | « content/common/view_messages.h ('k') | content/public/common/context_menu_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/context_menu_params.h

diff --git a/content/public/common/context_menu_params.h b/content/public/common/context_menu_params.h

index 49bd74f61f28f7ba0b523571ffcb744b36948e63..8d756bd78f150e829b7ac4c542969469232b5ad5 100644

--- a/content/public/common/context_menu_params.h

+++ b/content/public/common/context_menu_params.h

@@ -124,13 +124,13 @@ struct CONTENT_EXPORT ContextMenuParams {

// Whether context is editable.

bool is_editable;

-#if defined(OS_MACOSX) || defined(TOOLKIT_GTK)

+#if defined(OS_MACOSX) || defined(TOOLKIT_GTK) || defined(USE_AURA)

Peter Kasting 2013/12/03 22:52:35 Why don't we just nuke these ifdefs? These cover

pals 2013/12/04 12:54:50 Done.

// Writing direction menu items.

- // Currently only used on OS X and Linux.

+ // Currently only used on OS X, Linux Gtk and Aura.

int writing_direction_default;

int writing_direction_left_to_right;

int writing_direction_right_to_left;

-#endif // OS_MACOSX || defined(TOOLKIT_GTK)

+#endif // OS_MACOSX || TOOLKIT_GTK || USE_AURA

// These flags indicate to the browser whether the renderer believes it is

// able to perform the corresponding action.