chrome/app/chrome_command_ids.h - Issue 83163002: [Aura] Adding Writing direction to the context menu for Aura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_command_ids.h

Issue 83163002: [Aura] Adding Writing direction to the context menu for Aura. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Aura-CrOS-Win Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h » ('j') | chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/chrome_command_ids.h

diff --git a/chrome/app/chrome_command_ids.h b/chrome/app/chrome_command_ids.h

index eaf70f2dc23c37f092b5997a34af49f6a82c4bc3..679539f86d3a9c6a9888a70113807fb48ab762f0 100644

--- a/chrome/app/chrome_command_ids.h

+++ b/chrome/app/chrome_command_ids.h

@@ -228,10 +228,10 @@

#define IDC_SPELLCHECK_ADD_TO_DICTIONARY 41110

// Writing direction

-#define IDC_WRITING_DIRECTION_MENU 41120 // OSX and Linux Gtk only

-#define IDC_WRITING_DIRECTION_DEFAULT 41121 // OSX and Linux Gtk only

-#define IDC_WRITING_DIRECTION_LTR 41122 // OSX and Linux Gtk only

-#define IDC_WRITING_DIRECTION_RTL 41123 // OSX and Linux Gtk only

+#define IDC_WRITING_DIRECTION_MENU 41120 // OSX, Linux Gtk and Aura

Peter Kasting 2013/12/03 22:52:35 These cover most platforms, let's just remove thes

pals 2013/12/04 12:54:50 Done.

+#define IDC_WRITING_DIRECTION_DEFAULT 41121 // OSX, Linux Gtk and Aura

+#define IDC_WRITING_DIRECTION_LTR 41122 // OSX, Linux Gtk and Aura

+#define IDC_WRITING_DIRECTION_RTL 41123 // OSX, Linux Gtk and Aura

// Translate

#define IDC_TRANSLATE_OPTIONS_ALWAYS 42000