[Aura] Adding Writing direction to the context menu for Aura.

chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_TAB_CONTENTS_RENDER_VIEW_CONTEXT_MENU_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_TAB_CONTENTS_RENDER_VIEW_CONTEXT_MENU_VIEWS_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
@@ skipping 15 matching lines @@
 
   // Factory function to create an instance.
   static RenderViewContextMenuViews* Create(
       content::WebContents* web_contents,
       const content::ContextMenuParams& params);
 
   void RunMenuAt(views::Widget* parent,
                  const gfx::Point& point,
                  ui::MenuSourceType type);
 
+#if !defined(OS_WIN)

[Peter Kasting, 2013/11/22 21:53:03]

Don't add so many #ifs.  Use as few #ifs as possible, e.g. prototype and
implement everything for all platforms except for in some minimal number of
places in the implementation switch things off for the platforms you don't care
about.

[pals, 2013/11/25 06:28:13]

Done. Moved all the changes to a single #if.

+  // SimpleMenuModel::Delegate implementation.

[Peter Kasting, 2013/11/22 21:53:03]

You don't inherit from SimpleMenuModel::Delegate.  
Put these in the list with the other RenderViewContextMenuDelegate overrides, in
the appropriate place.

Make these private if they are not called directly by external classes.

[pals, 2013/11/25 06:28:13]

Done. Moved to private.

+  virtual void ExecuteCommand(int command_id, int event_flags) OVERRIDE;
+  virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
+  virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
+#endif // !OS_WIN
+
   // RenderViewContextMenuDelegate implementation.
   virtual void UpdateMenuItem(int command_id,
                               bool enabled,
                               bool hidden,
                               const string16& title) OVERRIDE;
 
  protected:
   RenderViewContextMenuViews(content::WebContents* web_contents,
                              const content::ContextMenuParams& params);
   // RenderViewContextMenu implementation.

[Peter Kasting, 2013/11/22 21:53:03]

Nit: While here: blank line above this

[pals, 2013/11/25 06:28:13]

Done.

   virtual void PlatformInit() OVERRIDE;
   virtual void PlatformCancel() OVERRIDE;
   virtual bool GetAcceleratorForCommandId(
       int command_id,
       ui::Accelerator* accelerator) OVERRIDE;
+#if !defined(OS_WIN)
+  virtual void AppendPlatformEditableItems() OVERRIDE;
+#endif // !OS_WIN
 
  private:
+#if !defined(OS_WIN)
+  // Adds writing direction submenu.
+  void AppendBidiSubMenu();
+
+  // Model for the BiDi input submenu.
+  ui::SimpleMenuModel bidi_submenu_model_;
+#endif // !OS_WIN
+
   scoped_ptr<views::MenuRunner> menu_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewContextMenuViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_TAB_CONTENTS_RENDER_VIEW_CONTEXT_MENU_VIEWS_H_