Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 831613002: Add WebNavigatorConnectCallbacks typedef. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, Marijn Kruisselbrink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add WebNavigatorConnectCallbacks typedef. Follow convention and introduce a typedef for the WebCallbacks<> that the WebNavigatorConnectProvider uses. R=haraken,mkwst BUG=445388 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187759

Patch Set 1 #

Patch Set 2 : make ConnectCallbacks be declared in terms of added typedef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/modules/navigatorconnect/NavigatorConnect.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M public/platform/WebNavigatorConnectProvider.h View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
Please take a look (whoever is around and willing to do so.. :) ) Just ...
5 years, 11 months ago (2014-12-29 16:28:04 UTC) #2
haraken
LGTM, though I'm not an owner of public/.
5 years, 11 months ago (2014-12-29 16:29:42 UTC) #3
Mike West
LGTM. You got lucky with our insatiable desire to check ALL THE EMAIL.
5 years, 11 months ago (2014-12-29 16:52:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831613002/20001
5 years, 11 months ago (2014-12-29 19:31:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/44315)
5 years, 11 months ago (2014-12-29 21:16:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831613002/20001
5 years, 11 months ago (2014-12-29 21:25:09 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2014-12-29 22:38:01 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187759

Powered by Google App Engine
This is Rietveld 408576698