HQ filtering for tiled/bleed drawBitmap

include/gpu/SkGpuDevice.h

 
 /*
  * Copyright 2010 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 
@@ skipping 179 matching lines @@
     bool shouldTileBitmap(const SkBitmap& bitmap,
                           const GrTextureParams& sampler,
                           const SkRect* srcRectPtr,
                           int maxTileSize,
                           int* tileSize,
                           SkIRect* clippedSrcRect) const;
     void internalDrawBitmap(const SkBitmap&,
                             const SkRect&,
                             const GrTextureParams& params,
                             const SkPaint& paint,
-                            SkCanvas::DrawBitmapRectFlags flags);
+                            SkCanvas::DrawBitmapRectFlags flags,
+                            bool bicubic);

[Stephen White, 2013/11/27 21:50:06]

Not a big deal, but it seems a little weird that bicubic is special in this
case. Would it be worth it to pass SkPaint::FilterLevel through instead, and let
the internal funcs decide what to do with each level? Could be a bit more
self-documenting at the call sites than a bool, too.

[bsalomon, 2013/11/27 22:11:51]

We could. The reason I did the bool was that the FilterLevel has already been
partially digested by this point (to determine the GrTextureParams). That can't
be deferred because GrTextureParams is necessary to perform cache lookups
(thanks to the GPUs that don't support mipping or wrap modes for NPOT texutres).

[Stephen White, 2013/11/27 22:31:13]

Yeah, that's what I figured. Like I said, no big deal and still LGTM. :)

     void drawTiledBitmap(const SkBitmap& bitmap,
                          const SkRect& srcRect,
                          const SkIRect& clippedSrcRect,
                          const GrTextureParams& params,
                          const SkPaint& paint,
                          SkCanvas::DrawBitmapRectFlags flags,
-                         int tileSize);
+                         int tileSize,
+                         bool bicubic);
 
     /**
      * Returns non-initialized instance.
      */
     GrTextContext* getTextContext();
 
     typedef SkBitmapDevice INHERITED;
 };
 
 #endif