Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc

Issue 831523005: Remove most native WebContents references from Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/external_prerender_handler_android.cc ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockTabDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
diff --git a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
index 0ad440eb47492d1bfc8fd0fa16c4bffa503f1b2c..2f9000979a0f3cf0a4b5d6a35be16aaf72b26772 100644
--- a/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
+++ b/chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc
@@ -84,10 +84,11 @@ int TabModelJniBridge::GetActiveIndex() const {
void TabModelJniBridge::CreateTab(WebContents* web_contents,
int parent_tab_id) {
JNIEnv* env = AttachCurrentThread();
- Java_TabModelJniBridge_createTabWithNativeContents(
+ Java_TabModelJniBridge_createTabWithWebContents(
env, java_object_.get(env).obj(),
web_contents->GetBrowserContext()->IsOffTheRecord(),
- reinterpret_cast<intptr_t>(web_contents), parent_tab_id);
+ web_contents->GetJavaWebContents().obj(),
+ parent_tab_id);
}
WebContents* TabModelJniBridge::GetWebContentsAt(int index) const {
« no previous file with comments | « chrome/browser/prerender/external_prerender_handler_android.cc ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockTabDelegate.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698