Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 831493002: replace COMPILE_ASSERT with static_assert in pdf/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in pdf/ BUG=442514 Committed: https://crrev.com/d517ba249308cf72a5c47f645ad121b9a13357cf Cr-Commit-Position: refs/heads/master@{#310012}

Patch Set 1 #

Patch Set 2 : rebase on master #

Total comments: 15

Patch Set 3 : fit nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -197 lines) Patch
M pdf/pdfium/pdfium_assert_matching_enums.cc View 1 2 1 chunk +194 lines, -193 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mostyn Bramley-Moore
@raymes: please take a look.
5 years, 11 months ago (2015-01-05 21:58:04 UTC) #2
raymes
lgtm https://codereview.chromium.org/831493002/diff/20001/pdf/pdfium/pdfium_assert_matching_enums.cc File pdf/pdfium/pdfium_assert_matching_enums.cc (right): https://codereview.chromium.org/831493002/diff/20001/pdf/pdfium/pdfium_assert_matching_enums.cc#newcode12 pdf/pdfium/pdfium_assert_matching_enums.cc:12: #define STATIC_ASSERT_MATCH(np_name, pdfium_name) \ nit: did you intentionally ...
5 years, 11 months ago (2015-01-05 22:26:38 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/831493002/diff/20001/pdf/pdfium/pdfium_assert_matching_enums.cc File pdf/pdfium/pdfium_assert_matching_enums.cc (right): https://codereview.chromium.org/831493002/diff/20001/pdf/pdfium/pdfium_assert_matching_enums.cc#newcode12 pdf/pdfium/pdfium_assert_matching_enums.cc:12: #define STATIC_ASSERT_MATCH(np_name, pdfium_name) \ On 2015/01/05 22:26:38, raymes wrote: ...
5 years, 11 months ago (2015-01-06 00:01:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831493002/40001
5 years, 11 months ago (2015-01-06 00:02:12 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-06 00:48:46 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 00:49:43 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d517ba249308cf72a5c47f645ad121b9a13357cf
Cr-Commit-Position: refs/heads/master@{#310012}

Powered by Google App Engine
This is Rietveld 408576698