Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 831483004: IDL: Make enums have global visibility (Closed)

Created:
5 years, 11 months ago by bashi
Modified:
5 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, tzik, eric.carlson_apple.com, dgrogan, aandrey+blink_chromium.org, jsbell+serviceworker_chromium.org, arv+blink, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, philipj_slow, nhiroki, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, jsbell+idb_chromium.org, michaeln, serviceworker-reviews, falken, kinuko+serviceworker, Inactive, cmumford, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Make enums have global visibility Before this CL, when the Blink IDL compiler processes an IDL file, it didn't lookup enum definitions which are defined in other files. This enforces developers write the same definitions in multiple places. To solve this problem, make enum definitions have global visibility by storing them in |component_info|. |InfoProvider| handles component dependency; enums defined in core/ can be visible to core/ and modules/, but enums defined in modules can only be visible to modules. BUG=390758 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -56 lines) Patch
M Source/bindings/scripts/code_generator_v8.py View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info_individual.py View 3 chunks +9 lines, -1 line 0 comments Download
M Source/bindings/scripts/utilities.py View 3 chunks +14 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestDictionary.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/core/TestInterface.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/modules/TestInterface5.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/modules/TestPartialInterface3.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 4 chunks +60 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 2 chunks +33 lines, -0 lines 0 comments Download
M Source/core/html/canvas/HitRegionOptions.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEventInit.idl View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.idl View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/modules/indexeddb/IDBIndex.idl View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.idl View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBVersionChangeEventInit.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescriptionInit.idl View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/modules/serviceworkers/WindowClient.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
bashi
PTAL?
5 years, 11 months ago (2015-01-16 05:06:18 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-16 05:11:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831483004/1
5 years, 11 months ago (2015-01-16 05:19:17 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 05:43:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188518

Powered by Google App Engine
This is Rietveld 408576698