Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 831453004: Do not depend on or try to configure pangocairo when use_pango == 0 (Closed)

Created:
5 years, 11 months ago by sfunkenhauser-google
Modified:
5 years, 11 months ago
Reviewers:
*Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not depend on or try to configure pangocairo when use_pango == 0 BUG= Committed: https://crrev.com/97a0a6304f0f7fb4f111b034bcf038f0fc95422a Cr-Commit-Position: refs/heads/master@{#311535}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Keep pangocario target unconditionally #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -29 lines) Patch
M build/linux/system.gyp View 1 1 chunk +32 lines, -28 lines 0 comments Download
M skia/skia_library.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
sfunkenhauser-google
5 years, 11 months ago (2015-01-13 22:54:17 UTC) #3
Nico
https://codereview.chromium.org/831453004/diff/1/build/linux/system.gyp File build/linux/system.gyp (right): https://codereview.chromium.org/831453004/diff/1/build/linux/system.gyp#newcode665 build/linux/system.gyp:665: 'type': 'none', Please keep the target available unconditionally, and ...
5 years, 11 months ago (2015-01-13 22:55:50 UTC) #4
sfunkenhauser-google
https://codereview.chromium.org/831453004/diff/1/build/linux/system.gyp File build/linux/system.gyp (right): https://codereview.chromium.org/831453004/diff/1/build/linux/system.gyp#newcode665 build/linux/system.gyp:665: 'type': 'none', On 2015/01/13 22:55:50, Nico wrote: > Please ...
5 years, 11 months ago (2015-01-14 17:13:59 UTC) #5
Nico
lgtm
5 years, 11 months ago (2015-01-14 18:43:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831453004/20001
5 years, 11 months ago (2015-01-14 18:50:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 19:56:44 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 19:58:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97a0a6304f0f7fb4f111b034bcf038f0fc95422a
Cr-Commit-Position: refs/heads/master@{#311535}

Powered by Google App Engine
This is Rietveld 408576698