Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1650)

Unified Diff: mojo/public/bindings/js/core_unittests.js

Issue 83143002: [Mojo] Improve JavaScript API for MojoReadMessage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/bindings/js/core_unittests.js
diff --git a/mojo/public/bindings/js/core_unittests.js b/mojo/public/bindings/js/core_unittests.js
index 555bdde90d0cb9b90422a9b8a2fd820ed6c7b72c..5cddc066d52f079d050a5dcf0d5419026fa94914 100644
--- a/mojo/public/bindings/js/core_unittests.js
+++ b/mojo/public/bindings/js/core_unittests.js
@@ -42,20 +42,20 @@ define([
var receiverData = new Uint8Array(50);
- var mesage = core.readMessage(
- pipe.handle1, receiverData, 10,
- core.READ_MESSAGE_FLAG_NONE)
-
- gtest.expectEqual(mesage.result, core.RESULT_OK,
- "mesage.result is " + mesage.result);
- gtest.expectEqual(mesage.bytesRead, 42,
- "mesage.bytesRead is " + mesage.bytesRead);
- gtest.expectEqual(mesage.handles.length, 0,
- "mesage.handles.length is " + mesage.handles.length);
-
- for (var i = 0; i < mesage.bytesRead; ++i) {
- gtest.expectEqual(receiverData[i], (i * i) & 0xFF,
- "receiverData[" + i + "] is " + receiverData[i]);
+ var read = core.readMessage(
+ pipe.handle1, core.READ_MESSAGE_FLAG_NONE)
+
+ gtest.expectEqual(read.result, core.RESULT_OK,
+ "read.result is " + read.result);
+ gtest.expectEqual(read.buffer.byteLength, 42,
+ "read.buffer.byteLength is " + read.buffer.byteLength);
+ gtest.expectEqual(read.handles.length, 0,
+ "read.handles.length is " + read.handles.length);
+
+ var memory = new Uint8Array(read.buffer);
+ for (var i = 0; i < memory.length; ++i) {
+ gtest.expectEqual(memory[i], (i * i) & 0xFF,
+ "memory[" + i + "] is " + memory[i]);
}
}
});

Powered by Google App Engine
This is Rietveld 408576698