Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 83143002: [Mojo] Improve JavaScript API for MojoReadMessage (Closed)

Created:
7 years, 1 month ago by abarth-chromium
Modified:
7 years ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

[Mojo] Improve JavaScript API for MojoReadMessage Originally, I tried to make the JavaScript bindings for the core Mojo APIs a literal translation of the C APIs, but that makes MojoReadMessage a bit awkward because C needs to worry much more about buffer allocation than JavaScript. In building towards using the hello_world_service, I found that it was much easier to push the MojoReadMessage pattern from connector.cc into C++ and make the JavaScript API a bit more idiomatic by just returning an ArrayBuffer for the message and an Array of handles. BUG=317398 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236999

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -61 lines) Patch
M gin/converter.h View 1 chunk +8 lines, -0 lines 0 comments Download
M gin/converter.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M gin/modules/module_registry.cc View 3 chunks +10 lines, -16 lines 0 comments Download
M mojo/public/bindings/js/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/bindings/js/core.cc View 1 5 chunks +47 lines, -30 lines 0 comments Download
M mojo/public/bindings/js/core_unittests.js View 1 chunk +14 lines, -14 lines 0 comments Download
M mojo/public/bindings/mojom_bindings_generator.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
abarth-chromium
7 years, 1 month ago (2013-11-22 09:34:42 UTC) #1
abarth-chromium
https://codereview.chromium.org/83143002/diff/1/mojo/public/bindings/mojom_bindings_generator.gypi File mojo/public/bindings/mojom_bindings_generator.gypi (right): https://codereview.chromium.org/83143002/diff/1/mojo/public/bindings/mojom_bindings_generator.gypi#newcode34 mojo/public/bindings/mojom_bindings_generator.gypi:34: '<(output_dir)/<(RULE_INPUT_ROOT).js', This change is a bit unrelated to the ...
7 years, 1 month ago (2013-11-22 09:35:25 UTC) #2
abarth-chromium
7 years, 1 month ago (2013-11-22 17:51:22 UTC) #3
abarth-chromium
This CL is ready for review. PTAL. Thanks!
7 years, 1 month ago (2013-11-23 17:17:28 UTC) #4
darin (slow to review)
LGTM
7 years, 1 month ago (2013-11-23 19:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/83143002/1
7 years, 1 month ago (2013-11-23 19:26:47 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=194410
7 years, 1 month ago (2013-11-23 19:38:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/83143002/1
7 years, 1 month ago (2013-11-23 20:31:11 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests, ...
7 years, 1 month ago (2013-11-23 21:09:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/83143002/340001
7 years, 1 month ago (2013-11-23 21:35:00 UTC) #10
commit-bot: I haz the power
7 years ago (2013-11-24 19:10:13 UTC) #11
Message was sent while issue was closed.
Change committed as 236999

Powered by Google App Engine
This is Rietveld 408576698