views: menu: Unwind multiple menu message loops eagerly with EXIT_ALL

views: menu: Unwind multiple menu message loops eagerly with EXIT_ALL

This allows menus to fully unwind after MenuController::CancelAll() is
called, without any additional events processed through the nested
dispatcher.

In particular, tests that cancel their menu cannot hang at the very end
of the test when there are no more events left to dispatch. Before, we
relied on some event - ANY event - getting through nested dispatch in
order to continue unwinding. This could cause hangs in test code when
there weren't any more events.

If a test calls MenuController::CancelAll() and then terminates its
outer RunLoop, the program should terminate. This change ensures that.

BUG=432576, 446335
TEST=interactive_ui_tests

Committed: https://crrev.com/8f674371c1e60b9de8ce6dd280ea77e1e592bc32
Cr-Commit-Position: refs/heads/master@{#310180}

[spang, 2015-01-06 00:34:47]

spang@chromium.org changed reviewers:
+ sky@chromium.org

[spang, 2015-01-06 00:52:49]

+ more specific bug

https://code.google.com/p/chromium/issues/detail?id=432576

[sky, 2015-01-06 01:00:15]

https://codereview.chromium.org/831413002/diff/1/ui/views/controls/menu/menu_...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/831413002/diff/1/ui/views/controls/menu/menu_...
ui/views/controls/menu/menu_controller.cc:447: TerminateNestedMessageLoop();
Move this up to around 437'ish. An else case for the if on 427.

[spang, 2015-01-06 19:14:12]

https://codereview.chromium.org/831413002/diff/1/ui/views/controls/menu/menu_...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/831413002/diff/1/ui/views/controls/menu/menu_...
ui/views/controls/menu/menu_controller.cc:447: TerminateNestedMessageLoop();
On 2015/01/06 01:00:15, sky wrote:
> Move this up to around 437'ish. An else case for the if on 427.

Done.

[spang, 2015-01-06 19:22:27]

https://codereview.chromium.org/831413002/diff/20001/ui/views/controls/menu/m...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/831413002/diff/20001/ui/views/controls/menu/m...
ui/views/controls/menu/menu_controller.cc:437: } else if (exit_type_ == EXIT_ALL
&& message_loop_depth_) {
Er, I think EXIT_DESTROYED also needs this treatment. Only EXIT_OUTERMOST is
different but we cannot reach here with that value since it is reset above..

Fixed.

[sky, 2015-01-06 22:36:28]

LGTM

[spang, 2015-01-06 22:43:13]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2015-01-06 22:43:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/831413002/40001

[commit-bot: I haz the power, 2015-01-07 00:19:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-07 00:21:37]

Patchset 3 (id:??) landed as
https://crrev.com/8f674371c1e60b9de8ce6dd280ea77e1e592bc32
Cr-Commit-Position: refs/heads/master@{#310180}