Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 831393006: Use fast_sqrt instead of std::sqrt in simulators. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use fast_sqrt instead of std::sqrt in simulators. This prevents clang from inlining and returning inconsistent results. R=bmeurer@chromium.org BUG=v8:3802 LOG=N Committed: https://crrev.com/f38e48be60df22320035db330c7275d6dff4d6c2 Cr-Commit-Position: refs/heads/master@{#26158}

Patch Set 1 #

Patch Set 2 : fix includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/arm/simulator-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/simulator-arm64.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/mips64/simulator-mips64.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/ppc/simulator-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
See test bot runs here: https://codereview.chromium.org/863583003
5 years, 11 months ago (2015-01-20 13:04:41 UTC) #1
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-20 13:05:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831393006/1
5 years, 11 months ago (2015-01-20 13:05:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/65)
5 years, 11 months ago (2015-01-20 13:09:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831393006/1
5 years, 11 months ago (2015-01-20 13:10:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831393006/20001
5 years, 11 months ago (2015-01-20 13:15:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-20 13:53:39 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 13:53:53 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f38e48be60df22320035db330c7275d6dff4d6c2
Cr-Commit-Position: refs/heads/master@{#26158}

Powered by Google App Engine
This is Rietveld 408576698