Issue 831373004: virtual/override specifier cleanup in ui/events/ozone/layout/xkb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 831373004: virtual/override specifier cleanup in ui/events/ozone/layout/xkb (Closed)

Created:
5 years, 11 months ago by kalyank

Modified:
5 years, 11 months ago

Reviewers:
spang

CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

virtual/override specifier cleanup in ui/events/ozone/layout/xkb Found when building with Ozone and use_xkbcommon=1 on Linux. BUG=417463 Committed: https://crrev.com/c7b2f88e9ce0b60e895e38f96e9bc9f6ffbd4bbe Cr-Commit-Position: refs/heads/master@{#310114}

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
	M	ui/events/ozone/layout/xkb/xkb_evdev_codes.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h	View		1 chunk	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831373004/1

5 years, 11 months ago (2015-01-06 18:35:17 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-06 18:55:43 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c7b2f88e9ce0b60e895e38f96e9bc9f6ffbd4bbe
Cr-Commit-Position: refs/heads/master@{#310114}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages