Issue 831323005: remove NewTexture

Issue 831323005: remove NewTexture (Closed)

Created:
5 years, 11 months ago by reed2

Modified:
5 years, 11 months ago

Reviewers:
bsalomon, robertphillips, Justin Novosad, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -13 lines)			Patch
	M	include/core/SkImage.h	View	1	2 chunks	+1 line, -9 lines	0 comments	Download
	M	src/image/SkImage_Gpu.cpp	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 12 (4 generated)

reed2

I don't think there are any callers... Remove? Change to take GrTexture?

5 years, 11 months ago (2015-01-11 20:34:08 UTC) #2

bsalomon

If we're not using it, then I'd say delete it. However, the cache issue has ...

5 years, 11 months ago (2015-01-12 15:42:00 UTC) #4

reed1

Lets either remove or re-parameterize it. If you're not ready to re-parameterize, I can delete ...

5 years, 11 months ago (2015-01-12 15:51:00 UTC) #6

bsalomon

On 2015/01/12 15:51:00, reed1 wrote: > Lets either remove or re-parameterize it. If you're not ...

5 years, 11 months ago (2015-01-12 20:38:50 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831323005/20001

5 years, 11 months ago (2015-01-13 11:51:34 UTC) #10

commit-bot: I haz the power

Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/4ef0c8aea2f966f42592202659afb21f6b0fb511

5 years, 11 months ago (2015-01-13 12:01:00 UTC) #11

Message was sent while issue was closed.

lgtm