Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 831313002: use conics for ovals and roundrects (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use conics for ovals and roundrects BUG=skia:

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : update ignore list #

Patch Set 4 : small fix to pathops #

Patch Set 5 : add nvpr failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -7 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 1 chunk +84 lines, -0 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (9 generated)
reed1
5 years, 11 months ago (2015-01-05 19:40:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831313002/1
5 years, 11 months ago (2015-01-05 19:41:21 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-05 19:41:21 UTC) #5
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-05 19:41:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831313002/20001
5 years, 11 months ago (2015-01-05 19:45:20 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-05 19:45:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1405)
5 years, 11 months ago (2015-01-05 19:51:21 UTC) #12
reed1
5 years, 11 months ago (2015-01-05 20:48:22 UTC) #14
reed1
updated ignore list, will investigate pathops failure now
5 years, 11 months ago (2015-01-05 20:49:02 UTC) #15
robertphillips
lgtm
5 years, 11 months ago (2015-01-05 20:49:23 UTC) #16
egdaniel
lgtm
5 years, 11 months ago (2015-01-05 21:28:37 UTC) #17
reed1
5 years, 11 months ago (2015-01-05 21:41:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831313002/80001
5 years, 11 months ago (2015-01-06 04:00:52 UTC) #21
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-06 04:00:56 UTC) #23
reed2
closing in favor of https://codereview.chromium.org/817283005/ (just to rebase expectations file)
5 years, 11 months ago (2015-01-06 04:06:04 UTC) #24
joshualitt
On 2015/01/06 04:06:04, reed2 wrote: > closing in favor of https://codereview.chromium.org/817283005/ > > (just to ...
5 years, 10 months ago (2015-02-24 21:44:26 UTC) #25
reed2
5 years, 10 months ago (2015-02-24 21:51:33 UTC) #26
On 2015/02/24 21:44:26, joshualitt wrote:
> On 2015/01/06 04:06:04, reed2 wrote:
> > closing in favor of https://codereview.chromium.org/817283005/
> > 
> > (just to rebase expectations file)
> 
> @reed did you mean to actually close this?

yup, closing now.

Powered by Google App Engine
This is Rietveld 408576698