Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 831293002: Fix one remaining misuse of FX_WSTRC on FX_WCHAR* vars. (Closed)

Created:
5 years, 11 months ago by brucedawson
Modified:
5 years, 11 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix one remaining misuse of FX_WSTRC on FX_WCHAR* vars. FX_WSTRC is only valid on arrays, not pointers. In this code it was being passed a pointer to a URL. This was found when integrating a change to FX_WSTRC that disallows pointer arguments. The consequence of this bug is that the URL will end up with incorrect lengths. It will be one character long in 32-bit builds, and three characters long in 64-bit builds (sizeof(WCHAR*)-1). R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/bbd41bbd5e4ae9ca4f4a800c955471e41a947d98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M xfa/src/fxfa/src/app/xfa_fftext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
brucedawson
I missed this one last time. This is particularly scary -- the URL would be ...
5 years, 11 months ago (2015-01-05 19:13:32 UTC) #2
Bo Xu
On 2015/01/05 19:13:32, brucedawson wrote: > I missed this one last time. > > This ...
5 years, 11 months ago (2015-01-05 19:43:18 UTC) #3
brucedawson
5 years, 11 months ago (2015-01-05 19:45:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bbd41bbd5e4ae9ca4f4a800c955471e41a947d98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698