Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 831283003: XFA: revert bb1405d - Create pdfium_unittests binary. (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
brucedawson
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: revert bb1405d - Create pdfium_unittests binary. Previous CL at https://codereview.chromium.org/830553002/ broke the standalone build. TBR=brucedawson@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/58043314d81b991f4ab44c43a2847b465a43d085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
5 years, 11 months ago (2015-01-05 18:41:08 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 58043314d81b991f4ab44c43a2847b465a43d085 (presubmit successful).
5 years, 11 months ago (2015-01-05 18:43:03 UTC) #2
brucedawson
5 years, 11 months ago (2015-01-05 18:46:31 UTC) #3
Message was sent while issue was closed.
That fixes the ninja generation steps, I'm back in business. Thanks.

lgtm

Powered by Google App Engine
This is Rietveld 408576698