Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3392)

Unified Diff: chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc

Issue 831283002: Hide the "Open PDF in Reader" bubble on navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc
diff --git a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc
index 2be219f62ea0e5b08e6d1a96bfa47297fb7fb874..f4a3c64aea9bb5a48c01ad15f9ec321adc887dfa 100644
--- a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc
+++ b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc
@@ -35,6 +35,10 @@ void OpenPDFInReaderView::Update(content::WebContents* web_contents) {
}
SetVisible(!!model_);
+
+ // Hide the bubble if it is currently shown and the icon is hidden.
+ if (!model_ && bubble_)
+ bubble_->GetWidget()->Hide();
}
void OpenPDFInReaderView::ShowBubble() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698