Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 831273002: fix local setter suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/local_computer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/completion_test_util.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart
index f59603cc98d11c9f8f2bd4f7cfd59deb03b04c66..c78a10decaae539dec40fb4c7d141608340c2338 100644
--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart
+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart
@@ -383,7 +383,10 @@ abstract class AbstractCompletionTest extends AbstractContextTest {
expect(element.name, equals(name));
// TODO (danrubel) assert setter param
//expect(element.parameters, isNull);
- expect(element.returnType, isNull);
+ // TODO (danrubel) it would be better if this was always null
+ if (element.returnType != null) {
+ expect(element.returnType, 'dynamic');
+ }
return cs;
}
@@ -758,6 +761,15 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
}
}
+ CompletionSuggestion assertSuggestLocalSetter(String name,
+ [CompletionRelevance relevance = CompletionRelevance.DEFAULT]) {
+ if (computer is LocalComputer) {
+ return assertSuggestSetter(name, relevance);
+ } else {
+ return assertNotSuggested(name);
+ }
+ }
+
CompletionSuggestion assertSuggestLocalTopLevelVar(String name,
String returnType, [CompletionRelevance relevance =
CompletionRelevance.DEFAULT]) {
@@ -1091,8 +1103,11 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
int T5;
var _T6;
String get T7 => 'hello';
+ set T8(int value) { }
Z D2() {int x;}
class X {
+ int get clog => 8;
+ set blog(value) { }
a() {
var f;
localF(int arg1) { }
@@ -1144,6 +1159,9 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
assertSuggestLocalTopLevelVar('_T6', null);
assertNotSuggested('==');
assertSuggestLocalGetter('T7', 'String');
+ assertSuggestLocalSetter('T8');
+ assertSuggestLocalGetter('clog', 'int');
+ assertSuggestLocalSetter('blog');
// TODO (danrubel) suggest HtmlElement as low relevance
assertNotSuggested('HtmlElement');
});
@@ -2095,10 +2113,10 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
int T1;
F1() { }
class X {X.c(); X._d(); z() {}}''');
- addSource('/testA.dart','''
+ addSource('/testA.dart', '''
part of libA;
class B { }''');
- addTestSource( '''
+ addTestSource('''
library libA;
import "/testB.dart";
part "/testA.dart";
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/local_computer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698