Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: pkg/analysis_server/lib/src/services/completion/local_computer.dart

Issue 831273002: fix local setter suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/local_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/local_computer.dart b/pkg/analysis_server/lib/src/services/completion/local_computer.dart
index e2059d01e93f84872300ec6d6db952a30d6c087d..78dcfa77f87fa06ada7e6b5b7dfd3c1951866f24 100644
--- a/pkg/analysis_server/lib/src/services/completion/local_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/local_computer.dart
@@ -199,17 +199,18 @@ class _LocalVisitor extends LocalDeclarationVisitor {
}
protocol.ElementKind kind;
String parameters;
+ TypeName returnType = declaration.returnType;
if (declaration.isGetter) {
kind = protocol.ElementKind.GETTER;
- parameters = '()';
+ parameters = null;
} else if (declaration.isSetter) {
if (excludeVoidReturn) {
return;
}
kind = protocol.ElementKind.SETTER;
- parameters = '(${declaration.returnType.toSource()} value)';
+ returnType = null;
} else {
- if (excludeVoidReturn && _isVoid(declaration.returnType)) {
+ if (excludeVoidReturn && _isVoid(returnType)) {
return;
}
kind = protocol.ElementKind.METHOD;
@@ -218,7 +219,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
bool isDeprecated = _isDeprecated(declaration);
CompletionSuggestion suggestion = _addSuggestion(
declaration.name,
- declaration.returnType,
+ returnType,
declaration.parent,
isDeprecated);
if (suggestion != null) {
@@ -226,7 +227,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
kind,
declaration.name,
parameters,
- declaration.returnType,
+ returnType,
declaration.isAbstract,
isDeprecated);
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698