Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 831263008: Oilpan: mark WebPageSerializerImpl as stack allocated. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: mark WebPageSerializerImpl as stack allocated. Along with declaring its GCed references as Member<>s. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M Source/web/WebPageSerializerImpl.h View 4 chunks +10 lines, -7 lines 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 11 months ago (2015-01-06 10:13:21 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-06 11:01:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831263008/1
5 years, 11 months ago (2015-01-06 11:26:01 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 13:46:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187914

Powered by Google App Engine
This is Rietveld 408576698