Issue 83123002: DevTools: Move DOMNode.appropriateSelectorFor() into DOMPresentationUtil.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83123002: DevTools: Move DOMNode.appropriateSelectorFor() into DOMPresentationUtil. (Closed)

Created:
7 years, 1 month ago by apavlov

Modified:
7 years, 1 month ago

Reviewers:
aandrey, eustas.com

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Move DOMNode.appropriateSelectorFor() into DOMPresentationUtil. This is a preliminary refactoring for the DOM node CSS selector construction. R=aandrey, eustas BUG=277286 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162535

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -35 lines)			Patch
M	LayoutTests/http/tests/inspector/inspect-element.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/inspector/layers-test.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/elements/move-node.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/layer-compositing-reasons.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/DOMAgent.js	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	Source/devtools/front_end/DOMPresentationUtils.js	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ElementsPanel.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/EventListenersSidebarPane.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/LayerTree.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/StylesSidebarPane.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/83123002/1

7 years, 1 month ago (2013-11-22 09:41:28 UTC) #3

Message was sent while issue was closed.

Change committed as 162535

Expand Messages | Collapse Messages