Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 831203003: [turbofan] Fix incorrect minus zero handling in the unit tests. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix incorrect minus zero handling in the unit tests. TEST=unittests R=jarin@chromium.org Committed: https://crrev.com/c329a49d69142d94d695889f1c92941ff79a448c Cr-Commit-Position: refs/heads/master@{#25956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -38 lines) Patch
M test/unittests/compiler/change-lowering-unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 9 chunks +24 lines, -16 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 6 chunks +10 lines, -6 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 8 chunks +12 lines, -11 lines 0 comments Download
M testing/gmock-support.h View 3 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-05 10:48:37 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-05 10:48:54 UTC) #2
Jarin
lgtm
5 years, 11 months ago (2015-01-05 12:00:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831203003/1
5 years, 11 months ago (2015-01-05 12:02:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-05 12:29:14 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 12:29:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c329a49d69142d94d695889f1c92941ff79a448c
Cr-Commit-Position: refs/heads/master@{#25956}

Powered by Google App Engine
This is Rietveld 408576698