Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/task.dart

Issue 831133004: Use closure conversion in new dart2js backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed redundant null-check Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/task.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/task.dart b/pkg/compiler/lib/src/js_backend/codegen/task.dart
index 756644e1bcb1ee4c2243ea9b29560ba82038c089..0068a2178f857b7e4829f1240591b2674e179e70 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/task.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/task.dart
@@ -44,8 +44,7 @@ class CspFunctionCompiler implements FunctionCompiler {
// TODO(karlklose,sigurm): remove and update dart-doc of [compile].
final FunctionCompiler fallbackCompiler;
- // TODO(sigurdm): Assign this.
- Tracer tracer;
+ Tracer get tracer => compiler.tracer;
CspFunctionCompiler(Compiler compiler, JavaScriptBackend backend)
: irBuilderTask = new IrBuilderTask(compiler),
@@ -98,7 +97,6 @@ class CspFunctionCompiler implements FunctionCompiler {
cps.FunctionDefinition compileToCpsIR(AstElement element) {
// TODO(sigurdm): Support these constructs.
if (element.isGenerativeConstructorBody ||
- element.enclosingClass is ClosureClassElement ||
element.isNative ||
element.isField) {
giveUp('unsupported element kind: ${element.name}:${element.kind}');
@@ -108,7 +106,9 @@ class CspFunctionCompiler implements FunctionCompiler {
if (cpsNode == null) {
giveUp('unable to build cps definition of $element');
}
+ traceGraph("IR Builder", cpsNode);
new UnsugarVisitor(glue).rewrite(cpsNode);
+ traceGraph("Unsugaring", cpsNode);
return cpsNode;
}
@@ -131,7 +131,6 @@ class CspFunctionCompiler implements FunctionCompiler {
cps.FunctionDefinition optimizeCpsIR(cps.FunctionDefinition cpsNode) {
// Transformations on the CPS IR.
- traceGraph("IR Builder", cpsNode);
TypePropagator typePropagator = new TypePropagator<TypeMask>(
compiler.types,
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart ('k') | pkg/compiler/lib/src/js_emitter/code_emitter_task.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698