Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 831133004: Use closure conversion in new dart2js backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed redundant null-check Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 05bacf57ade352d0497e8eedf6e42ae3311e5a1f..cf32d70856c138f45ef28b62ea2febc98da253af 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -424,4 +424,33 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
// TODO: implement SuperInitializer
}
+ @override
+ js.Expression visitCreateBox(tree_ir.CreateBox node) {
+ return new js.ObjectInitializer([]);
+ }
+
+ @override
+ js.Expression visitCreateClosureClass(tree_ir.CreateClosureClass node) {
+ registry.registerInstantiatedClass(node.classElement);
+ return new js.New(glue.closureClassConstructorAccess(node.classElement),
+ node.arguments.map(visitExpression).toList());
+ }
+
+ @override
+ js.Expression visitGetField(tree_ir.GetField node) {
+ return new js.PropertyAccess.field(
+ visitExpression(node.object),
+ glue.instanceFieldPropertyName(node.field));
+ }
+
+ @override
+ void visitSetField(tree_ir.SetField node) {
+ js.PropertyAccess field =
+ new js.PropertyAccess.field(
+ visitExpression(node.object),
+ glue.instanceFieldPropertyName(node.field));
+ js.Assignment asn = new js.Assignment(field, visitExpression(node.value));
+ accumulator.add(new js.ExpressionStatement(asn));
+ visitStatement(node.next);
+ }
}
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698