Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 831113002: Cleanup: More override fixes - another round. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
reed2, reed1
CC:
reviews_skia.org, Nico
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cleanup: More override fixes - another round. BUG=skia:3075 TEST=ninja -C out/Debug TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/aa458fb20a4350da581f8ceec69ea16eec295ced

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -217 lines) Patch
M bench/PremulAndUnpremulAlphaOpsBench.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M bench/RectoriBench.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M bench/RefCntBench.cpp View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -4 lines 0 comments Download
M bench/RegionContainBench.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M bench/ScalarBench.cpp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M gm/aaclip.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/aarectmodes.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M gm/alphagradients.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/beziers.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M gm/bitmaprecttest.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M gm/bitmapscroll.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M gm/blurrect.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M gm/blurs.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M gm/circularclips.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M gm/clip_strokerect.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gm/coloremoji.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M gm/filltypes.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -4 lines 0 comments Download
M gm/filltypespersp.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -5 lines 0 comments Download
M gm/filterbitmap.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M gm/filterindiabox.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M gm/fontmgr.cpp View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +9 lines, -9 lines 0 comments Download
M gm/fontscaler.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download
M gm/getpostextpath.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download
M gm/giantbitmap.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download
M gm/glyph_pos.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M gm/glyph_pos_align.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M gm/gradients.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +6 lines, -6 lines 0 comments Download
M gm/gradtext.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M gm/hairlines.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M gm/hittestpath.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -3 lines 0 comments Download
M gm/imageblur.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -3 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleRegion.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleRepeatTile.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleRotateCircles.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M samplecode/SampleShaders.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleSlides.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleStrokePath.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleText.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleTextAlpha.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleTextOnPath.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleVertices.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/animator/SkDisplayMath.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/animator/SkDraw3D.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/animator/SkDrawClip.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawDash.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawDiscrete.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawExtraPathEffect.cpp View 1 2 3 4 5 6 7 7 chunks +8 lines, -8 lines 0 comments Download
M src/animator/SkDrawFull.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawGradient.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/animator/SkDrawLine.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawPaint.h View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download
M src/animator/SkDrawPath.h View 1 2 3 4 5 6 7 3 chunks +13 lines, -13 lines 0 comments Download
M src/animator/SkDrawPoint.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawSaveLayer.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M src/animator/SkDrawShader.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/animator/SkDrawText.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M src/animator/SkDrawTextBox.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M src/animator/SkDrawTo.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/animator/SkDrawTransparentShader.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkHitClear.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/animator/SkHitTest.h View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M src/animator/SkMatrixParts.h View 1 2 3 4 5 7 chunks +12 lines, -12 lines 0 comments Download
M src/animator/SkMemberInfo.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M src/animator/SkPaintPart.h View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M src/animator/SkPathParts.h View 1 2 3 4 5 13 chunks +14 lines, -14 lines 0 comments Download
M src/animator/SkSnapshot.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkTextOnPath.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkTextToPath.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M tools/PictureResultsWriter.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tfarina
Submitting this batch.
5 years, 11 months ago (2015-01-06 01:08:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831113002/220001
5 years, 11 months ago (2015-01-06 01:08:56 UTC) #3
commit-bot: I haz the power
Committed patchset #12 (id:220001) as https://skia.googlesource.com/skia/+/aa458fb20a4350da581f8ceec69ea16eec295ced
5 years, 11 months ago (2015-01-06 01:18:55 UTC) #4
reed2
5 years, 11 months ago (2015-01-06 03:57:54 UTC) #6
Message was sent while issue was closed.
if you are going to make massive changes like this, and not have someone review
them (was this blocking something?), please follow the new convention.

virtual void foo();  // override

becomes

void foo() SK_OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698