Close embedded extension options page when the overlay is hidden

chrome/browser/resources/extensions/extensions.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 <include src="extension_code.js">
 <include src="extension_commands_overlay.js">
 <include src="extension_error_overlay.js">
 <include src="extension_focus_manager.js">
 <include src="extension_list.js">
@@ skipping 386 matching lines @@
     var pageDiv = $('extension-settings');
     if (node) {
       pageDiv.style.width = window.getComputedStyle(pageDiv).width;
       document.body.classList.add('no-scroll');
     } else {
       document.body.classList.remove('no-scroll');
       pageDiv.style.width = '';
     }
 
     var currentlyShowingOverlay = ExtensionSettings.getCurrentOverlay();
-    if (currentlyShowingOverlay)
+    if (currentlyShowingOverlay) {
       currentlyShowingOverlay.classList.remove('showing');
+      cr.dispatchSimpleEvent($('overlay'), 'cancelOverlay');

[Finnur, 2015/01/05 10:07:26]

The bug states that the overlay erroneously closes. I don't see how manually
closing it here fixes the issue...?

[robwu, 2015/01/05 10:14:29]

Oops, wrong bug number. It is crbug.com/445978.

+    }
 
     if (node)
       node.classList.add('showing');
 
     var pages = document.querySelectorAll('.page');
     for (var i = 0; i < pages.length; i++) {
       pages[i].setAttribute('aria-hidden', node ? 'true' : 'false');
     }
 
     $('overlay').hidden = !node;
@@ skipping 36 matching lines @@
 
   // Export
   return {
     ExtensionSettings: ExtensionSettings
   };
 });
 
 window.addEventListener('load', function(e) {
   extensions.ExtensionSettings.getInstance().initialize();
 });