Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: content/browser/accessibility/browser_accessibility_manager_win.h

Issue 830943004: Improve the notifications sent from AXTree updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback, add missing call to parent class Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_MANAGER_WIN_H_ 5 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_MANAGER_WIN_H_
6 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_MANAGER_WIN_H_ 6 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_MANAGER_WIN_H_
7 7
8 #include <oleacc.h> 8 #include <oleacc.h>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 // Return a pointer to the object corresponding to the given windows-specific 53 // Return a pointer to the object corresponding to the given windows-specific
54 // unique id, does not make a new reference. 54 // unique id, does not make a new reference.
55 BrowserAccessibilityWin* GetFromUniqueIdWin(LONG unique_id_win); 55 BrowserAccessibilityWin* GetFromUniqueIdWin(LONG unique_id_win);
56 56
57 // Called when |accessible_hwnd_| is deleted by its parent. 57 // Called when |accessible_hwnd_| is deleted by its parent.
58 void OnAccessibleHwndDeleted(); 58 void OnAccessibleHwndDeleted();
59 59
60 protected: 60 protected:
61 // BrowserAccessibilityManager methods 61 // BrowserAccessibilityManager methods
62 virtual void OnRootChanged(ui::AXNode* new_root) override; 62 void OnAtomicUpdateFinished(
63 bool root_changed,
64 const std::vector<ui::AXTreeDelegate::Change>& changes) override;
63 65
64 private: 66 private:
65 // Give BrowserAccessibilityManager::Create access to our constructor. 67 // Give BrowserAccessibilityManager::Create access to our constructor.
66 friend class BrowserAccessibilityManager; 68 friend class BrowserAccessibilityManager;
67 69
68 // Track the most recent object that has been asked to scroll and 70 // Track the most recent object that has been asked to scroll and
69 // post a notification directly on it when it reaches its destination. 71 // post a notification directly on it when it reaches its destination.
70 // TODO(dmazzoni): remove once http://crbug.com/113483 is fixed. 72 // TODO(dmazzoni): remove once http://crbug.com/113483 is fixed.
71 BrowserAccessibilityWin* tracked_scroll_object_; 73 BrowserAccessibilityWin* tracked_scroll_object_;
72 74
73 // A mapping from the Windows-specific unique IDs (unique within the 75 // A mapping from the Windows-specific unique IDs (unique within the
74 // browser process) to accessibility ids within this page. 76 // browser process) to accessibility ids within this page.
75 base::hash_map<long, int32> unique_id_to_ax_id_map_; 77 base::hash_map<long, int32> unique_id_to_ax_id_map_;
76 78
77 // Set to true if we need to fire a focus event on the root as soon as 79 // Set to true if we need to fire a focus event on the root as soon as
78 // possible. 80 // possible.
79 bool focus_event_on_root_needed_; 81 bool focus_event_on_root_needed_;
80 82
81 DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityManagerWin); 83 DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityManagerWin);
82 }; 84 };
83 85
84 } // namespace content 86 } // namespace content
85 87
86 #endif // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_MANAGER_WIN_H_ 88 #endif // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_MANAGER_WIN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698