Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 83093005: remove kA1_Config, as it is no longer supported (Closed)

Created:
7 years, 1 month ago by reed1
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove kA1_Config, as it is no longer supported BUG= R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=12384

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -373 lines) Patch
M gm/bitmapcopy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/bitmapfilters.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkBitmap.h View 3 chunks +0 lines, -22 lines 0 comments Download
M include/core/SkImageDecoder.h View 1 chunk +1 line, -1 line 1 comment Download
M samplecode/SampleApp.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M samplecode/SampleFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/animator/SkDrawBitmap.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M src/core/SkBitmap.cpp View 14 chunks +4 lines, -64 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D src/core/SkBlitter_A1.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
M src/core/SkCoreBlitters.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/core/SkScalerContext.cpp View 3 chunks +68 lines, -23 lines 0 comments Download
M src/effects/SkTransparentShader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 5 chunks +1 line, -55 lines 0 comments Download
M src/utils/debugger/SkObjectParser.cpp View 1 chunk +2 lines, -2 lines 1 comment Download
M tests/BitmapCopyTest.cpp View 11 chunks +12 lines, -56 lines 0 comments Download
M tests/BitmapGetColorTest.cpp View 2 chunks +0 lines, -63 lines 0 comments Download
M tests/BlitRowTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageDecodingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
7 years, 1 month ago (2013-11-22 21:17:20 UTC) #1
hal.canary
Patch set 2 is a bad upload.
7 years ago (2013-11-25 14:17:58 UTC) #2
djsollen
I can't see patch set 2 either. https://codereview.chromium.org/83093005/diff/1/include/core/SkBitmap.h File include/core/SkBitmap.h (left): https://codereview.chromium.org/83093005/diff/1/include/core/SkBitmap.h#oldcode50 include/core/SkBitmap.h:50: kA1_Config, this ...
7 years ago (2013-11-25 15:14:14 UTC) #3
reed1
rebased. ptal
7 years ago (2013-11-25 15:52:39 UTC) #4
djsollen
lgtm
7 years ago (2013-11-25 18:45:17 UTC) #5
reed1
Committed patchset #3 manually as r12384 (presubmit successful).
7 years ago (2013-11-25 18:58:37 UTC) #6
scroggo
https://codereview.chromium.org/83093005/diff/130001/include/core/SkImageDecoder.h File include/core/SkImageDecoder.h (right): https://codereview.chromium.org/83093005/diff/130001/include/core/SkImageDecoder.h#newcode189 include/core/SkImageDecoder.h:189: void setPrefConfigTable(const SkBitmap::Config pref[5]); Why did this change? The ...
7 years ago (2013-12-02 19:34:35 UTC) #7
cpu_(ooo_6.6-7.5)
Scroggo, the answer to your '6' question is that bad things happen. For example chrome ...
7 years ago (2013-12-04 20:01:52 UTC) #8
reed1
7 years ago (2013-12-04 20:07:21 UTC) #9
Message was sent while issue was closed.
On 2013/12/04 20:01:52, cpu wrote:
> Scroggo, the answer to your '6' question is that bad things happen. For
example
> chrome extension system serializes skbitmaps to disk (including the config of
> course) so currently in debug ToT chrome explodes because there is no 6.
> 
> I think it needs extensions so I don't think the waterfall is going to reflect
> this.
> 
> Now of course the fault is not exactly with skia since they did not force
> clients to literally serialize skbitmaps.

Doh! Skia does not yet have a stable way to serialize any of its data
structures. We are very interested in such a thing (esp. at the SkPicture
level), but so far we have not done it.

Powered by Google App Engine
This is Rietveld 408576698