Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: runtime/vm/isolate.cc

Issue 83093004: Fix shutdown races and move signal blocking into profiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/profiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index c3e92fab9102c29c098c621e43e61990bb8735ef..3b271051c6c5ff3459065db73f3b6d30e109b5a5 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -25,7 +25,6 @@
#include "vm/profiler.h"
#include "vm/reusable_handles.h"
#include "vm/service.h"
-#include "vm/signal_handler.h"
#include "vm/simulator.h"
#include "vm/stack_frame.h"
#include "vm/stub_code.h"
@@ -340,7 +339,6 @@ Isolate::~Isolate() {
}
void Isolate::SetCurrent(Isolate* current) {
- ScopedSignalBlocker ssb;
Isolate* old_isolate = Current();
if (old_isolate != NULL) {
ProfilerManager::DescheduleIsolate(old_isolate);
@@ -704,11 +702,6 @@ void Isolate::Shutdown() {
StackZone stack_zone(this);
HandleScope handle_scope(this);
- ScopedSignalBlocker ssb;
-
- ProfilerManager::DescheduleIsolate(this);
-
-
if (FLAG_print_object_histogram) {
heap()->CollectAllGarbage();
object_histogram()->Print();
@@ -750,6 +743,7 @@ void Isolate::Shutdown() {
// TODO(5411455): For now just make sure there are no current isolates
// as we are shutting down the isolate.
SetCurrent(NULL);
+ ProfilerManager::DescheduleIsolate(this);
ProfilerManager::ShutdownIsolateForProfiling(this);
}
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698