Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 830923003: dart2js: make "boilerplate" function in Native generator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/native_generator.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index dd3ddc4a50b945cbef4d7d82c2c58683de728f3f..3fa2c8f1683675b33c93a84dfdf1b49a4b13622c 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -944,23 +944,14 @@ class OldEmitter implements Emitter {
mainCallClosure = backend.emitter.staticFunctionAccess(main);
}
- NativeGenerator nativeGenerator =
- new NativeGenerator(generateEmbeddedGlobalAccess);
- if (backend.needToInitializeIsolateAffinityTag) {
- buffer.write(
- jsAst.prettyPrint(
- nativeGenerator.generateIsolateAffinityTagInitialization(),
- compiler, monitor: compiler.dumpInfoTask));
- buffer.write(N);
- }
- if (backend.needToInitializeDispatchProperty) {
- assert(backend.needToInitializeIsolateAffinityTag);
- buffer.write(
- jsAst.prettyPrint(
- nativeGenerator.generateDispatchPropertyNameInitialization(),
- compiler, monitor: compiler.dumpInfoTask));
- buffer.write(N);
- }
+ bool initializeAffinityTag = backend.needToInitializeIsolateAffinityTag;
+ jsAst.Statement nativeBoilerPlate =
+ NativeGenerator.generateIsolateAffinityTagInitialization(
+ generateEmbeddedGlobalAccess,
+ initializeIsolateAffinityTag: initializeAffinityTag,
+ initializeDispatchProperty: backend.needToInitializeDispatchProperty);
+ buffer.write(jsAst.prettyPrint(nativeBoilerPlate,
+ compiler, monitor: compiler.dumpInfoTask));
jsAst.Expression currentScriptAccess =
generateEmbeddedGlobalAccess(embeddedNames.CURRENT_SCRIPT);
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/native_generator.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698