Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 830923003: dart2js: make "boilerplate" function in Native generator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index 5121465f30116663caba3272165b82768ab0a4a3..04a806fb3efe92b4bff8d0a85ffe1b2a1f5e3576 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -943,23 +943,13 @@ class OldEmitter implements Emitter {
mainCallClosure = backend.emitter.staticFunctionAccess(main);
}
- NativeGenerator nativeGenerator =
- new NativeGenerator(generateEmbeddedGlobalAccess);
- if (backend.needToInitializeIsolateAffinityTag) {
- buffer.write(
- jsAst.prettyPrint(
- nativeGenerator.generateIsolateAffinityTagInitialization(),
- compiler, monitor: compiler.dumpInfoTask));
- buffer.write(N);
- }
- if (backend.needToInitializeDispatchProperty) {
- assert(backend.needToInitializeIsolateAffinityTag);
- buffer.write(
- jsAst.prettyPrint(
- nativeGenerator.generateDispatchPropertyNameInitialization(),
- compiler, monitor: compiler.dumpInfoTask));
- buffer.write(N);
- }
+ bool initializeAffinityTag = backend.needToInitializeIsolateAffinityTag;
+ jsAst.Statement nativeBoilerPlate = NativeGenerator.generateBoilerPlate(
+ generateEmbeddedGlobalAccess,
+ initializeIsolateAffinityTag: initializeAffinityTag,
+ initializeDispatchProperty: backend.needToInitializeDispatchProperty);
+ buffer.write(jsAst.prettyPrint(nativeBoilerPlate,
+ compiler, monitor: compiler.dumpInfoTask));
jsAst.Expression currentScriptAccess =
generateEmbeddedGlobalAccess(embeddedNames.CURRENT_SCRIPT);

Powered by Google App Engine
This is Rietveld 408576698