Issue 830923002: Do not reduce effect phis of loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 830923002: Do not reduce effect phis of loops. (Closed)

Created:
5 years, 11 months ago by Jarin

Modified:
5 years, 11 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev, titzer

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Do not reduce effect phis for loops. This prevents eliminating effectful statements before the loop. BUG= Committed: https://crrev.com/bdf446f59007e1a19ffea21d550db4b186790e98 Cr-Commit-Position: refs/heads/master@{#25953}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	src/compiler/control-reducer.cc	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
	A +	test/mjsunit/compiler/regress-ntl-effect.js	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830923002/40001

5 years, 11 months ago (2015-01-03 12:19:10 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-03 12:46:10 UTC) #7

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/bdf446f59007e1a19ffea21d550db4b186790e98
Cr-Commit-Position: refs/heads/master@{#25953}