Push: move push_messaging_dispatcher files into push_messaging directory.

Push: move push_messaging_dispatcher files into push_messaging directory.

Committed: https://crrev.com/6e54061cc9ae3d7e41164208f9c7e6a237632bac
Cr-Commit-Position: refs/heads/master@{#310104}

[Michael van Ouwerkerk, 2015-01-05 18:12:10]

mvanouwerkerk@chromium.org changed reviewers:
+ peter@chromium.org

[Michael van Ouwerkerk, 2015-01-05 18:12:11]

Peter, could you take a look please?

[Peter Beverloo, 2015-01-05 18:13:07]

On 2015/01/05 18:12:11, Michael van Ouwerkerk wrote:
> Peter, could you take a look please?

What is the reason that we want to do this? There's only two files. It may be
easier to just add per-file OWNERS for now.

[Michael van Ouwerkerk, 2015-01-05 18:17:34]

On 2015/01/05 18:13:07, Peter Beverloo wrote:
> On 2015/01/05 18:12:11, Michael van Ouwerkerk wrote:
> > Peter, could you take a look please?
> 
> What is the reason that we want to do this? There's only two files. It may be
> easier to just add per-file OWNERS for now.

It's mainly for the OWNERS part, but also for consistency with
content/browser/push_messaging. This is not unprecedented. On the other hand,
per-file owners for content/renderer seem less common, and they're not entirely
robust across file renames.

[mlamouri (slow - plz ping), 2015-01-06 10:05:35]

On 2015/01/05 18:17:34, Michael van Ouwerkerk wrote:
> On 2015/01/05 18:13:07, Peter Beverloo wrote:
> > On 2015/01/05 18:12:11, Michael van Ouwerkerk wrote:
> > > Peter, could you take a look please?
> > 
> > What is the reason that we want to do this? There's only two files. It may
be
> > easier to just add per-file OWNERS for now.
> 
> It's mainly for the OWNERS part, but also for consistency with
> content/browser/push_messaging. This is not unprecedented. On the other hand,
> per-file owners for content/renderer seem less common, and they're not
entirely
> robust across file renames.

Moving those files sounds like a good idea to me. There are a lot of files in
content/renderer/ and having more sub-directory wouldn't hurt for visibility.
Furthermore, now, after the holidays, is probably a good time to reduce the
annoyance to people working on that code.

lgtm

[mlamouri (slow - plz ping), 2015-01-06 10:06:08]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Peter Beverloo, 2015-01-06 11:38:00]

On 2015/01/05 18:17:34, Michael van Ouwerkerk wrote:
> On 2015/01/05 18:13:07, Peter Beverloo wrote:
> > On 2015/01/05 18:12:11, Michael van Ouwerkerk wrote:
> > > Peter, could you take a look please?
> > 
> > What is the reason that we want to do this? There's only two files. It may
be
> > easier to just add per-file OWNERS for now.
> 
> It's mainly for the OWNERS part, but also for consistency with
> content/browser/push_messaging. This is not unprecedented. On the other hand,
> per-file owners for content/renderer seem less common, and they're not
entirely
> robust across file renames.

lgtm on the improving consistency argument, thanks :)

[Michael van Ouwerkerk, 2015-01-06 11:39:59]

mvanouwerkerk@chromium.org changed reviewers:
+ avi@chromium.org

[Michael van Ouwerkerk, 2015-01-06 11:40:00]

Avi, could you take a look as content owner please?

[Avi (use Gerrit), 2015-01-06 15:48:12]

On 2015/01/06 11:40:00, Michael van Ouwerkerk wrote:
> Avi, could you take a look as content owner please?

I'm down with that.

LGTM

[Michael van Ouwerkerk, 2015-01-06 15:55:58]

The CQ bit was checked by mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2015-01-06 15:56:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/830853005/1

[commit-bot: I haz the power, 2015-01-06 17:35:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-06 17:36:14]

Patchset 1 (id:??) landed as
https://crrev.com/6e54061cc9ae3d7e41164208f9c7e6a237632bac
Cr-Commit-Position: refs/heads/master@{#310104}